fktn-k / fkYAML / 28925996281

100%

Build Type

push

github

Committed by web-flow

Commit Message

Fix brace initialization of empty collection nodes (issue #502) (#524)

* Fix brace initialization of empty collection nodes

Preserve the type of empty mapping and sequence nodes when they are passed
through brace initialization, e.g. node{node::mapping()}.

Previously this form selected the initializer-list constructor and treated the
single empty mapping node as a sequence element. Track whether initializer-list
entries were created directly from a basic_node and unwrap the narrow empty
collection case without changing existing scalar initializer-list behavior.

Add regression coverage for empty mapping/sequence brace initialization and keep
single scalar brace initialization as a one-element sequence.

* Fix node_ref_storage conversion for initializer-list nodes

Allow node_ref_storage to be implicitly constructed from basic_node lvalues and
rvalues so initializer_list elements preserve the direct-node marker across
compilers.

This keeps node{node::mapping()} and node{node::sequence()} on the intended
empty collection unwrap path instead of falling through to the generic variadic
constructor.

* Keep explicit node_ref_storage constructors

Restore explicit on the direct basic_node node_ref_storage constructors and
handle the initializer-list empty collection case through the variadic
constructor path instead.

GCC/Clang select the variadic constructor when creating initializer_list
elements for node{node::mapping()} and node{node::sequence()}. Mark that
storage as a direct node only when it receives exactly one basic_node argument,
so the initializer-list constructor can preserve empty collection nodes without
allowing broader implicit conversions.

Update the constructor documentation and add coverage for duplicate-anchor
destruction.

Coverage Stats

1416 of 1424 branches covered (99.44%)

Branch coverage included in aggregate %.

12 of 12 new or added lines in 2 files covered. (100.0%)

1 existing line in 1 file now uncovered.

5161 of 5164 relevant lines covered (99.94%)

403.35 hits per line