asticode / go-astisub / 28923816677

80%

push

github

fix: nil-pointer panic in WriteToSSA when Metadata is nil (#145)

* fix: nil-pointer panic in WriteToSSA when Metadata is nil

WriteToSSA dereferenced s.Metadata unconditionally when computing the
v4plus flag, but Metadata is an optional *Metadata that only ReadFromSSA
populates. Reading any other format (WebVTT, SRT, TTML, STL) and writing
SSA therefore panicked with a nil-pointer dereference.

Guard the read: nil Metadata now yields v4plus=false (legacy [V4 Styles]
output), matching the existing nil-safe newSSAScriptInfo one line above.

Adds TestWriteToSSANilMetadata as a regression test.

* Address review feedback on TestWriteToSSANilMetadata

Move the nil-metadata comment above the subtitles literal and simplify
its wording, and replace the post-write asserts with assert.NotPanics
to focus the test on the regression (writing SSA no longer panics).

1 of 1 new or added line in 1 file covered. (100.0%)

3152 of 3958 relevant lines covered (79.64%)

60.88 hits per line