source-academy / py-slang / 28920042345

78%

push

github

Fix CSE Machine visualizer display bugs: position-0 node mislabeling, verbose builtin display (#230)

* Fix CSE Machine mislabeling real nodes at source position 0 as synthetic

serializeControlItem inferred "synthetic runtime-generated node" (e.g.
implicit range() start/step bounds) from indexInSource being pinned to
0, but a real node whose token is literally the first token of the
source also has indexInSource 0. Single-token leaf nodes (Identifier,
bare Literal) at that position were misclassified and rendered with a
generic KIND_LABEL fallback and no line metadata instead of their real
text — e.g. `print(1)` on line 1 showed the callee as "var" instead of
"print" at the step it's pushed onto control, while the identical code
one line down rendered correctly.

Fix: mark runtime-fabricated tokens with an explicit `synthetic` flag
on Token instead of inferring syntheticness from position, and check
that flag in serializeControlItem.

Fixes #228.

* Show builtin function name only on CSE Machine stash, not full repr()

formatValue()'s "builtin" case rendered the same verbose Python-repr()
string used for actual print()/repr() output (<built-in function xxx>),
unlike every other callable value in the visualizer: closures already
show just their bare name (funcName / "lambda"), with the "this is a
function" fact carried separately via `label`/metadata rather than
baked into the display string.

Bring builtins in line with that: formatValue() now returns just the
name, and typeTranslator() gains a "builtin" case
("builtin_function_or_method", matching CPython's
type(print).__name__) so `label` still distinguishes builtins from
user-defined closures ("function") without parsing the display text.

Scoped to the CSE Machine's own serialization layer
(PyCseMachinePlugin.ts / types.ts) only — src/utils/stringify.ts and
src/stdlib/utils.ts, which produce real Python repr()/print() output,
are untouched.

Fixes #229.

* Address review feedback: dedupe typeTran... (continued)

2602 of 3643 branches covered (71.42%)

Branch coverage included in aggregate %.

11 of 11 new or added lines in 4 files covered. (100.0%)

6106 of 7613 relevant lines covered (80.2%)

14070.68 hits per line