decentraland / worlds-content-server / 28908243089

89%

main: 91%

Build Type

Pull #504

github

Committed by LautaroPetaccio

Commit Message

perf: skip the permission check on resume batches of a partial upload

each batch of a multi-request upload was re-running the slow external
deployment-permission check. resume batches now skip it, but only when the
signer is the deployer who created the pending record — creating it required
passing the check, uploaded bytes are hash-verified against the staged
manifest, and finalize re-runs the full validation before anything goes live.
any other signer takes the full staging validation, so a third party can't
ride an existing upload's fast path.

the pending row is still upserted on every batch (always before storing
files): re-asserting it resurrects the row if a competing overlapping upload
replaced it between requests, keeping this batch's staged content protected
from garbage collection.

also moves the pre-finalize newer-deployment check to immediately before the
deploy write (after the slow full validation) to minimize the window in which
a concurrent newer deploy could be silently undeployed, and centralizes GC
pending-key computation in the pending-scenes manager.

adds tests: permission check runs once at staging plus once at finalize, and
a different signer resuming someone else's upload is rejected.

Pull Request Pull Request #504: feat: support partial (multi-request) scene uploads

Coverage Stats

1462 of 1753 branches covered (83.4%)

Branch coverage included in aggregate %.

143 of 161 new or added lines in 9 files covered. (88.82%)

4 existing lines in 3 files now uncovered.

3115 of 3397 relevant lines covered (91.7%)

76.52 hits per line