supabase / pg_net / 28907124781

93%

push

github

fix: segfault on MacOS

Improves the `multi_socket_cb` implementation for both kqueue and epoll by doing the following:

For kqueue:

* Fixes the leaks in the filters because the `sock_info->action` was not being updated. This also lead to a use-after-free bug and sometimes made the tests on macOS fail due to a segfault. All these bugs are fixed.
* Correctly checks the return value of `curl_multi_assign` and raises a Postgres error if the call fails.

For epoll:

* Correctly checks the return value of `curl_multi_assign` and raises a Postgres error if the call fails.
* Correctly handle the case when `what == CURL_POLL_INOUT` by setting the right `EPOLLIN` and `EPOLLOUT` combination in `ev.events` member.
* Sets a sentinel value in the call to `curl_multi_assign` the first time `multi_socket_cb` is called for a socket fd and removes it when `what == CURL_POLL_REMOVE`. This clarifies the intent of the `curl_multi_assign` call because the older code assignments to `socket_exists` variable were never read and were confusing.

5 of 5 new or added lines in 1 file covered. (100.0%)

500 of 535 relevant lines covered (93.46%)

221.74 hits per line