decentraland / worlds-content-server / 28904098114

89%

main: 91%

Build Type

Pull #504

github

Committed by LautaroPetaccio

Commit Message

fix: address partial-upload review findings

- reject a stale pending upload that would finalize over a newer scene on the
  same parcels (checked at staging entry and again right before deploy),
  mirroring catalyst's newer-deployment guard; a resumed hours-old upload can
  no longer silently roll back a newer deployment
- garbage collection re-checks the current pending scenes before each delete
  batch, so content staged by an upload that starts mid-sweep isn't reclaimed
- run the cumulative size check before the pending upsert, so an over-budget
  request no longer destroys another deployer's in-flight overlapping upload
- restore the combined uploaded+missing file error report in the full
  validation path (validateAll short-circuited after the split)
- parallelize staged file storage, collapse redundant storage lookups, only
  delete the pending row on a vanilla deploy when one exists (best-effort, so a
  cleanup error can't fail an already-committed deploy)
- centralize PENDING_DEPLOYMENT_TTL in the pending-scenes manager (deleteExpired
  and getActivePendingKeys), removing the duplicated constant from the eviction
  job and GC handler

adds regression tests for the stale-overwrite and over-budget cases.

Pull Request Pull Request #504: feat: support partial (multi-request) scene uploads

Coverage Stats

1455 of 1748 branches covered (83.24%)

Branch coverage included in aggregate %.

138 of 157 new or added lines in 9 files covered. (87.9%)

4 existing lines in 3 files now uncovered.

3110 of 3393 relevant lines covered (91.66%)

75.11 hits per line