decentraland / worlds-content-server / 28892218433

89%

main: 91%

Build Type

Pull #504

github

Committed by LautaroPetaccio

Commit Message

feat: support partial (multi-request) scene uploads

allow a world scene's content to be uploaded across several POST /entities
requests via an optional `partial=true` form field. content is staged in a
standalone pending_scenes table until every referenced file is present, at
which point the completing request runs the full validation + deploy and the
world goes live (auto-finalize); earlier requests return 202 with the
still-missing hashes.

- new pending_scenes table (migration 0025) + pending-scenes-manager. it is
  standalone (no fk to worlds) so a half-uploaded world never leaks into
  listings or validity checks before it is live
- new partial-deployments logic component
- validateFiles split into validateUploadedFiles (both phases) and
  validateNoMissingFiles (finalize only); new validator.validateStaging runs
  everything except content-completeness and the storage-backed size check;
  size is checked cumulatively as content accumulates
- at most one pending scene per world + overlapping parcels; a newer partial
  deploy replaces it
- deployment-ttl check anchored on the pending row's created_at so an upload
  can span longer than the ttl; a successful deploy removes the pending row
- garbage collection keeps non-expired pending hashes; the eviction job also
  removes expired pending rows (PENDING_DEPLOYMENT_TTL, default 24h)
- requests without the flag behave exactly as before

Pull Request Pull Request #504: feat: support partial (multi-request) scene uploads

Coverage Stats

1447 of 1741 branches covered (83.11%)

Branch coverage included in aggregate %.

113 of 136 new or added lines in 9 files covered. (83.09%)

4 existing lines in 3 files now uncovered.

3088 of 3378 relevant lines covered (91.42%)

70.57 hits per line