28885911377
87%

Ran 07 Jul 2026 05:35PM UTC

Jobs 1

Files 264

Run time 1min

Badge

Embed ▾

Committed 07 Jul 2026 05:27PM UTC coverage: 87.228% (-0.005%) from 87.233%

Build # 28885911377

Build Type

push

github

Committed by

drmingdrmer

Commit Message

test: tolerate the injected fatal in the 1795 replication test

# Summary

Fix a latent race in `storage_error_stops_replication` that made it fail
intermittently in CI. The test injects a one-shot storage read error and then
propagated the result of `add_learner` with `?`, but that injected error is by
design fatal to RaftCore, so `add_learner` can legitimately return it instead
of `Ok`.

# Details

The injected `limited_get_log_entries` error is read by the replication stream
to the new learner, reported to RaftCore as `Notification::StorageError`, and
converted into `Fatal::StorageError`, which stops the core and fails any
in-flight `add_learner` with the same error. The call therefore races the
shutdown: it returns `Ok` when the membership response wins and the injected
`StorageError` when the fatal wins. Discard the result instead of using `?`;
the assertion that replication never retried with a malformed AppendEntries is
the actual behavior under test and holds in both outcomes.

- Fixes #1795 test flakiness

Coverage Stats

17415 of 19965 relevant lines covered (87.23%)

158888.87 hits per line

Coverage Regressions

Lines	Coverage	∆	File
1	92.4	-0.1%	openraft/src/core/raft_core.rs
1	83.33	0.0%	openraft/src/metrics/serde_instant.rs

Jobs

ID	Job ID	Ran	Files	Coverage
1	28885911377.1	07 Jul 2026 05:35PM UTC	264	87.23	GitHub Action Run

databendlabs / openraft / 28885911377
87%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Coverage Regressions

Jobs

Source Files on build 28885911377

databendlabs / openraft / 28885911377 87%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Coverage Regressions

Jobs

Source Files on build 28885911377

databendlabs / openraft / 28885911377
87%

README BADGES
x