python-discord / site / 28878612405

100%

master: 100%

push

github

Fix n+1 queries (#1633)

* Fix expanded infractions n+1 query

* Fix n+1 query in users

Since the role validator was in the model, a query to the roles table had to be ran for each row returned by the user query.

Moving this validation to the serialiser allowed all roles to be validated in the same query as the fetch.

Since the validation is done at the serialiser level, this removed the need for the validators to be in the model at all.

* Further test coverage for users endpoint

37 of 37 new or added lines in 4 files covered. (100.0%)

4657 of 4657 relevant lines covered (100.0%)

1.0 hits per line