stacklok / toolhive / 28852900937

68%

Build Type

push

github

Committed by web-flow

Commit Message

Expose UpstreamFilter through authserver.New facade (#5733)

* Expose UpstreamFilter through authserver.New facade

WithUpstreamFilter (added in #5725) was only reachable via the
low-level handlers.NewHandler constructor, so a caller using the
public authserver.New facade had no way to install a filter.

Add Config.UpstreamFilter and thread it into the handler options
built for handlers.NewHandler, mirroring the existing refresher
wiring. A nil filter preserves current behavior.

* Guard UpstreamFilter misuse in authserver.Config

Addresses stacklok/toolhive#5733 review comments:
- MEDIUM pkg/authserver/config.go (3533389467): Validate() now rejects
  UpstreamFilter set with fewer than 2 upstreams, since computeChain
  never consults the filter in that case and it would silently no-op.
- LOW pkg/authserver/config.go (3533389470): doc comment now warns that
  a typed-nil concrete pointer is a non-nil interface value and will
  still be wired in.

* Clean up UpstreamFilter test hygiene in integration tests

Addresses stacklok/toolhive#5733 review comments:
- MEDIUM pkg/authserver/integration_test.go (3533389480): wire
  options.upstreamFilter into setupTestServer and
  setupTestServerWithOIDCProvider's Config literals so withUpstreamFilter
  no longer silently no-ops when applied to those helpers (or to
  setupTestServerWithMockOIDC, which delegates to setupTestServer).
- LOW pkg/authserver/integration_test.go (3533389475): extract the
  shared client->authorize->first-upstream->callback boilerplate into
  runFirstLeg, reused by runChainFlow and the new filter test.
- LOW pkg/authserver/integration_test.go (3533389477): reword the new
  test's doc comment, which overstated a "second failure signal" from
  mockoidc that can't actually occur given the test's control flow.

Coverage Stats

15 of 15 new or added lines in 2 files covered. (100.0%)

9 existing lines in 2 files now uncovered.

72813 of 107185 relevant lines covered (67.93%)

64.81 hits per line