28851993640
68%

Ran 07 Jul 2026 08:25AM UTC

Jobs 1

Files 795

Run time 2min

Badge

Embed ▾

Committed 07 Jul 2026 08:19AM UTC coverage: 67.871% (+0.01%) from 67.857%

Build # 28851993640

Build Type

push

github

Committed by

web-flow

Commit Message

Drop unconditional ACL password guard from auth server Redis storage (#5734)

NewRedisStorage rejected any config with an empty Password, contradicting
the toolhive-core Config type it consumes (Password "may be empty when the
server does not require authentication") and the sibling transport/session
RedisStorage, which has no such guard. The requirement originated as a
Phase-1 design choice in #3639 and was carried forward through the
toolhive-core migration in #5318; it blocks passwordless Redis (in-cluster
auth-disabled Valkey, dev miniredis) for no security reason the auth server
itself needs.

Drop the guard and keep only the storage-specific keyPrefix invariant.
Connection validation and Ping verification remain delegated to
tcredis.NewClient, so a misconfigured password still surfaces as a
Redis-native auth error from the Ping. Add a passwordless-miniredis test
and trim the validation table to the keyPrefix case.

Coverage Stats

72738 of 107171 relevant lines covered (67.87%)

64.73 hits per line

Coverage Regressions

Lines	Coverage	∆	File
2	96.04	0.0%	pkg/authserver/storage/memory.go
2	88.24	-5.88%	pkg/vmcp/backendregistry/registry.go
2	82.29	-0.21%	pkg/vmcp/composer/workflow_engine.go
2	62.12	0.26%	pkg/workloads/manager.go

Jobs

ID	Job ID	Ran	Files	Coverage
1	28851993640.1	07 Jul 2026 08:25AM UTC	795	67.87	GitHub Action Run

stacklok / toolhive / 28851993640
68%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Coverage Regressions

Jobs

Source Files on build 28851993640

stacklok / toolhive / 28851993640 68%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Coverage Regressions

Jobs

Source Files on build 28851993640

stacklok / toolhive / 28851993640
68%

README BADGES
x