umputun / tg-spam / 28850477820

84%

Build Type

push

github

Committed by umputun

Commit Message

fix: scope locator primary keys by gid to prevent cross-group clobbering

messages.hash and spam.user_id were single-column primary keys while the
upserts overwrite gid on conflict, so two instances with different
--instance-id sharing one database destroy each other's rows: the same text
(or a spam flag for the same user id) posted in group B clobbers group A's
row, silently breaking /spam reply-matching and the spam-info/unban buttons.

Keys are now composite: (gid, hash) and (gid, user_id). Existing databases
upgrade at startup inside the existing migration transaction - sqlite rebuilds
the tables (indexes recreated by InitTable right after), postgres swaps the PK
constraint in place. Both paths are idempotent; old data can't violate the new
keys since uniqueness on the single column implies uniqueness on the pair. The
gid columns are checked per table via catalog metadata, the spam gid backfill
goes through Adopt, and the postgres constraint name is quoted with
pq.QuoteIdentifier.

Tests: shared-DB isolation for both engines, postgres legacy-PK migration
(with nullable gid to exercise the implicit SET NOT NULL from ADD PRIMARY KEY),
partial-schema migration, and a full-row assertion on the sqlite rebuild copy.
The generic migration test now runs on postgres too via engine-aware helpers.
README documents that instances sharing one postgres database must upgrade
together.

Coverage Stats

128 of 177 new or added lines in 1 file covered. (72.32%)

2 existing lines in 2 files now uncovered.

8700 of 10424 relevant lines covered (83.46%)

251.01 hits per line