tubedude / finance-elixir / f8c0e4196f1f3a3930b408ccf11aca5264f89eaa-PR-29

100%

master: 100%

Pull #29

github

Address idiomatic review: doc drift and edge notes

- The CashFlow moduledoc and xnpv docs still described Actual/365 as fixed; it's
  the default now, selectable via :basis. xnpv/3's doc and the :basis schema doc
  omitted :basis and xnfv. Corrected.
- normalize's comment claimed only same-date flows merge, but under a 30/360
  basis distinct dates can map to the same period; a DayCount note now explains it.
- Document xnfv's forward-compounding overflow — it raises on an absurd rate where
  xnpv underflows, the one spot the dated pipeline's overflow-safety doesn't hold.
- Split the DayCount type into builtin | module; pin conventional?([]) / [0, 0].

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AVibXT2w1dEdVtMHqffFKn

44 of 44 new or added lines in 5 files covered. (100.0%)

489 of 489 relevant lines covered (100.0%)

62599.92 hits per line