tubedude / finance-elixir / f720d42ee3598f6cf63555d91e758bca223b21ef-PR-29

100%

master: 100%

Pull #29

github

Apply day-count review from Kip Cole

- year_fraction callback becomes /3 (from, to, opts) so conventions that need
  context — Actual/Actual ICMA, 30E/360 ISDA — fit later without a breaking
  change; the built-in static conventions ignore opts.
- Document the conventions precisely: actual_actual is Actual/Actual (ISDA), not
  Excel's basis-1 average-year method; thirty_360 is basic US/NASD with no
  end-of-February rule; thirty_e_360's Feb 28 -> Mar 1 counts 3 days (doctest'd).
- Add a multi-year ACT/ACT test straddling a leap year to pin the per-year sum,
  and correct a test comment that wrongly equated ACT/ACT with Excel YEARFRAC 1.
- Point the business/252 recipe at ex_tempo (not the unrelated `tempo` package),
  with the advice to materialize a static ANBIMA business-day set.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01AVibXT2w1dEdVtMHqffFKn

44 of 44 new or added lines in 5 files covered. (100.0%)

489 of 489 relevant lines covered (100.0%)

59964.27 hits per line