babelfish-for-postgresql / babelfish_extensions / 28820267910

78%

BABEL_6_X_DEV: 78%

Build Type

push

github

Committed by web-flow

Commit Message

[Insert Exec Redesign] Remove legacy tuple-store INSERT EXEC path (#4883)

Babelfish carried two parallel INSERT EXEC implementations gated by the
enable_new_insert_exec GUC. The redesigned DestReceiver/temp-table path
(PR0–PR4, #4780–#4847) has proven stable, so this commit removes the
original tuple-store approach and the GUC entirely, leaving a single
code path.

This drops the GUC, the per-estate insert_exec flag, the legacy grammar
rules that fed InsertStmt.execStmt, the tuplestore drain logic in
exec_stmt_exec and pltsql_inline_handler, the called_from_tsql_insert_exec
hook function, and the cross-database schema rewriting for execStmt. The
DestReceiver is also optimized to hold the temp buffer table open for the
lifetime of a result set rather than reopening it per tuple.

Task: BABEL-5522

Authored By: Arvind Sharma arvshaa@amazon.com
Co-author: Rucha Kulkarni <ruchask@amazon.com>

Coverage Stats

23 of 23 new or added lines in 6 files covered. (100.0%)

2 existing lines in 1 file now uncovered.

55946 of 72075 relevant lines covered (77.62%)

389514.84 hits per line