ghga-de / ghga-jsonsubschema / 28808579241

83%

main: 81%

Build Type

Pull #15

github

Committed by Cito

Commit Message

Support exact negation of integer schemas

Negating an integer schema no longer raises UnsupportedNegatedNumeric
but yields the exact complement: all non-numeric types, the integers
outside the bounds, and "number but not an integer", represented by
the standard fragment {"not": {"multipleOf": 1}} embedded in a number
schema and a notInteger flag that meet/join/is_subtype and the
uninhabited check understand. A trivial multipleOf of 1 is negated as
the integer case; only non-trivial multipleOf negation still raises.

Unions produced by negation record the negated schema, so subtyping
against them reduces to an exact emptiness test of the meet. Other
unions involving not-integer schemas are decided by an exact coverage
check across all members, since no single member needs to contain the
left-hand side.

Also fix pre-existing defects surfaced while verifying soundness:
- subtyping against a negated number range whose gap contains no
  integer wrongly returned False for integer schemas
- the uninhabited check for multipleOf ignored zero and negative
  multiples within the bounds; it now tests exactly whether a
  multiple exists in the interval
- enum values were validated against the latest jsonschema draft,
  crashing on draft-4 boolean exclusiveMinimum/exclusiveMaximum; they
  are now validated with the configured draft, extended so that
  int-equivalent floats count as integers
- subtype checks of single-value numeric schemas and of integers
  against fractional multipleOf factors (e.g. 0.5) are now exact

Pull Request Pull Request #15: Improve package quality (GSI-2374)

Coverage Stats

634 of 812 branches covered (78.08%)

Branch coverage included in aggregate %.

392 of 440 new or added lines in 5 files covered. (89.09%)

15 existing lines in 2 files now uncovered.

1353 of 1569 relevant lines covered (86.23%)

0.86 hits per line