scriptype / writ-cms / 28798924418

50%

Build Type

push

github

Committed by scriptype

Commit Message

Implement delete attachment in updatePost

a delete button for each attachment &
a cancel button for each new selected file.

Deletions are processed together with the updatePost request. So a
deletedAttachments field is added into payload.data. Probably a separate
endpoint for attachments would be better. But it's a future thing.

To keep the file input updated after cancelling files, some manual DOM
plumbing is done.

Deletions are optimistically reflected on the UI after the prompt is
confirmed (e.g. the attachment disappears from screen). But then after
hitting save and before the post is done updating, the attachment
becomes visible again. That's because internal states are cleared too
eagerly, before waiting for request's resolve. Maybe fix that sometime

Coverage Stats

650 of 1221 branches covered (53.24%)

Branch coverage included in aggregate %.

0 of 45 new or added lines in 3 files covered. (0.0%)

1 existing line in 1 file now uncovered.

2242 of 4195 relevant lines covered (53.44%)

1557.27 hits per line