umputun / remark42 / 28798150072

85%

master: 85%

Build Type

Pull #2110

github

Committed by paskal

Commit Message

Fix comment-tree pagination under-filling exact-fit subtrees

The limit() boundary used >=, so a subtree that fit the page exactly was
treated as overflow and dropped — under-filling the final page (e.g.
limit=5 over subtrees 3,2 returned only the first subtree, 3 comments,
instead of both). Change it to > so an exact-fit subtree is included;
the first node is still always returned in full and larger subtrees
still overflow to the next page.

Adds table tests for MakeTree's limit/offset pagination and countReplies,
and updates the /find consistent-count expectations for the corrected
boundary.

Pull Request Pull Request #2110: Fix comment-tree pagination under-filling exact-fit subtrees

Coverage Stats

1 of 1 new or added line in 1 file covered. (100.0%)

188 existing lines in 4 files now uncovered.

6456 of 7590 relevant lines covered (85.06%)

38.07 hits per line