adobe / spectrum-web-components / 28785206495
96%

DEFAULT BRANCH: main
Ran
Jobs 1
Files 402
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 96.257%. Remained the same
28785206495

push

github

web-flow 
fix(tabs): correct selection indicator position in RTL (#6466)

* fix(tabs): correct selection indicator position in RTL

The indicator's resting position uses inset-inline-start (right edge
in RTL), but the JS always measured/translated it from the left edge,
so it landed in the wrong spot in RTL. Detect direction via
getComputedStyle and offset from the right edge in RTL, and flip
transform-origin accordingly.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

* chore: add changeset for tabs RTL selection indicator fix

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

* fix(tabs): use this.dir getter for RTL detection in selection indicator

Aligns with the existing this.dir usage in getNavigationDelta rather than
introducing a second RTL-detection pattern via getComputedStyle.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

* fix(tabs): resolve RTL direction via getComputedStyle and react to runtime dir changes

this.dir only reflects an attribute set on the tabs element itself, not
direction inherited from an ancestor or <html>, which is how most apps set
RTL. Revert to getComputedStyle(this).direction, matching the same
correctness rationale already documented in
focusgroup-navigation-controller.ts.

Also observe dir attribute mutations on the document root and nearest
[dir] ancestor (mirroring placement-controller.ts) so the indicator
recalculates when direction flips after initial render, instead of
waiting on an unrelated resize event.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

---------

Co-authored-by: Rajdeep Chandra <rajdeepc@adobe.com>
Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
Co-authored-by: Piyush Vashisht <piyush17303@iiitd.ac.in>

6016 of 6458 branches covered (93.16%)

Branch coverage included in aggregate %.

37903 of 39169 relevant lines covered (96.77%)

461.19 hits per line

Jobs
ID Job ID Ran Files Coverage
1 28785206495.1 402
96.26
 GitHub Action Run
Source Files on build 28785206495