humanspeak / svelte-json-view-lite / 28783117040

84%

main: 87%

push

github

fix(a11y): omit aria-selected on treeitems to match upstream (#29)

* test(a11y): assert treeitems omit aria-selected (red)

Pin issue #24 as a failing baseline: upstream react-json-view-lite
omits aria-selected on treeitems, but the port renders a literal
aria-selected="false" on every node — a non-selectable tree should
not advertise a selection state at all.

The e2e now asserts zero [role=treeitem][aria-selected="false"], after
first proving the /test/basic sample has both expanded and leaf
treeitems so the absence check can't pass vacuously.

Fails against current markup (26 nodes carry the attribute). Turns
green once ExpandableObject, JsonPrimitiveValue, and EmptyObject drop
aria-selected — option 1 (match upstream) per the issue.

Refs #24

* fix(a11y): omit aria-selected on treeitems to match upstream

The port rendered a literal aria-selected="false" on every treeitem.
Since aria-* are not boolean attributes, Svelte emitted the string form
on all ~26 nodes of a typical tree — a divergence from upstream
react-json-view-lite and a false selection affordance: a read-only
viewer has no selection model, so advertising aria-selected on every
node is incorrect ARIA (and per APG, unselected nodes should omit it).

Drop aria-selected from ExpandableObject, JsonPrimitiveValue, and
EmptyObject. Suppress Svelte's a11y_role_has_required_aria_props (which
treats aria-selected as required on treeitem via option inheritance) —
omission is the intentional, upstream-matching, APG-aligned choice.

Turns the red e2e green (0 unselected aria-selected nodes) and also
trims bytes per node, which compounds on large trees.

Closes #24

185 of 259 branches covered (71.43%)

Branch coverage included in aggregate %.

3 of 3 new or added lines in 3 files covered. (100.0%)

253 of 265 relevant lines covered (95.47%)

222.25 hits per line