jhheider / penknife / 28778353418

76%

Build Type

push

github

Committed by web-flow

Commit Message

CLI correctness and message fixes; graceful gh fallback (#29)

* CLI correctness and message fixes; graceful gh fallback

From the correctness and error-idioms reviews.

Correctness (cli.rs):
- The path resolver no longer rewrites backslashes. That corrupted a
  Unix filename containing a literal backslash, and worse, it
  disagreed with the scanner's rel_path (which does no such rewrite),
  so on Windows a lookup could miss the stored entry and create a
  duplicate gist. It now matches the scanner exactly.
- `status` surfaces read and live-check errors instead of treating an
  unreadable file as empty (which faked drift) or exiting 0 after a
  network failure (which gave a hook false confidence). Any error now
  makes the run exit 5.
- A failed local-state save after a `push`/`url` now exits 5 rather
  than 0, so a script knows the gist is live but the local record is
  stale (which would otherwise cause a duplicate push next time). The
  URL still prints to stdout first.
- The bare `Err(2)` gets the named `EXIT_USAGE` constant.

Messages:
- `resolve_token` treats an unspawnable `gh` (not installed) as "no
  token" rather than a confusing "failed to run gh" error, so the
  caller shows the actionable sign-in guidance.
- The TUI's dead-end "No GitHub token available." becomes a shared
  hint that names the fix and the restart. The "store save failed"
  family (inconsistent wording and casing, leaking the internal
  "store" concept) unifies on "saving local state failed".
- `url`'s drift message now suggests inspecting before overwriting,
  matching `push`. `report_gist_error` prints the inner gist error
  instead of leaking PkError's "Gist error:" wrapper.
- Subcommand help now states the auth requirement, and `search`
  notes it covers .md files.

color-eyre stays (the earlier anyhow swap was gratuitous churn).

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* Normalize rel_paths to forward slashes; gate coverage to main

The Windows test fa... (continued)

Coverage Stats

18 of 67 new or added lines in 6 files covered. (26.87%)

3 existing lines in 1 file now uncovered.

3064 of 7628 relevant lines covered (40.17%)

2.1 hits per line