kaidokert / fixed-bigint-rs / 28763742719

97%

main: 97%

Pull #134

github

Address PR #134 review: git dep on const-num-traits instead of [patch.crates-io]

Both chatgpt-codex-connector (P1) and coderabbit (Minor) flagged the
`[patch.crates-io]` block as fragile for the prototype-consumer use
case:

- `[patch.crates-io]` is only read from the root workspace manifest.
  Downstream prototypes (rsa/new_reduce, ed25519_heapless) that
  depend on this branch via a git or workspace dep would still see
  `const-num-traits = "0.1.1"` unpatched, resolve it from crates.io,
  and fail to link the new `FromByteSlice` bound. Each consumer
  would have to duplicate the patch block in their own root
  manifest.
- The `version = "0.1.1"` requirement paired with a `0.1.2-alpha.0`
  patch relied on `cargo update` having explicitly landed the git
  version in Cargo.lock. On a clean resolve, Cargo excludes
  pre-release versions from `^0.1.1`-shaped requirements by
  default, so the patch would be "unused" and Cargo would silently
  keep 0.1.1.

Fix by replacing the patch + version-dep pair with a direct git
dep on the tag. Downstream picks up the tag transitively; no
patch block anywhere. Applied to all three workspace members that
depend on const-num-traits (root, ct-fixtures, panic-free-audit).

Reverts back to `version = "0.1.2"` (crates.io) as a one-line
change once const-num-traits 0.1.2 is on crates.io.

62 of 68 new or added lines in 2 files covered. (91.18%)

3197 of 3280 relevant lines covered (97.47%)

302.83 hits per line