ArduPilot / MethodicConfigurator / 28761266543

94%

push

github

refactor(log_analysis): fix memory, error handling, and design issues

- Cap raw_messages storage to 1 sample per message type (MAX_SAMPLES_PER_TYPE)
  to prevent memory exhaustion on large .bin log files
- Remove bare `except Exception` from _iter_messages; exceptions now propagate
  naturally without redundant log-then-re-raise
- Convert stateless LogQualityChecker class to module-level functions
  validate_fmt_schema() and validate_configuration_steps()
- Move _process_ver() and _parse_msg_version() to extract_param_defaults.py
  where their only caller lives; remove them from the shared extraction module
- Relocate the early-exit guard for MSG version fallback to the call site,
  removing the misleading in-function short-circuit
- load_configuration_steps() now returns None on I/O/JSON error instead of {}
  so callers can distinguish file failure from a legitimately empty config
- StepValidationResult.name now sources from the "why" field (step purpose)
  instead of "blog_text" (a UI hyperlink label)
- Fix test_configuration_steps_schema.py hardcoded relative path to use
  Path(__file__).parent.parent so tests pass from any working directory

Signed-off-by: Dr.-Ing. Amilcar do Carmo Lucas <amilcar.lucas@iav.de>

2022 of 2094 branches covered (96.56%)

12756 of 13530 relevant lines covered (94.28%)

2.82 hits per line