paskal / spot / 28754879929

84%

master: 84%

push

github

config: fix inline comment stripping and simplified-playbook options

- scriptCommand stripped a single-line script from the first '#' anywhere,
  which mangled '#' inside a token (e.g. ${VAR#prefix}) or inside a quoted
  string (e.g. "fix #1"). It now strips only a real trailing shell comment
  via the stripTrailingComment Cmd method: a '#' that starts a word
  (preceded by whitespace) and is outside quotes. Comment stripping is
  still needed so lines joined with '; ' do not have the comment swallow
  the next command.
- The simplified-playbook conversion never transferred the top-level
  'options' block to the generated task, so those options were silently
  ignored on every command; it also relied on the fragile partial decode
  of the failed full-parse for user/ssh_key/shell fields. It now carries
  options into the generated task (they propagate to all commands) and
  copies user, ssh_key and the shell fields into the playbook explicitly.

Tests cover the comment cases (${VAR#...}/quoted-#), the simple-playbook
option/field propagation for both yaml and toml, and that cli overrides
still win over the copied top-level values.

23 of 23 new or added lines in 2 files covered. (100.0%)

3211 of 3815 relevant lines covered (84.17%)

59.92 hits per line