kubernetes-sigs / external-dns / 28751058508
84%

DEFAULT BRANCH: master
Ran
Jobs 2
Files 158
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 83.426% (+0.04%) from 83.384%
28751058508

push

github

web-flow 
fix(dnsimple): read back all supported record types and fix record lookup by type (#6517)

* fix(dnsimple): include AAAA records when reading from the provider

The DNSimple provider only read back A, CNAME and TXT records, so any
existing AAAA record was invisible to external-dns. On every reconcile the
record looked missing, external-dns tried to create it again, and DNSimple
rejected the duplicate.

AAAA records were already being created fine, they just were not read back,
so the create and read paths disagreed. Adding AAAA to the records we read
lets external-dns see the existing record and update it instead of trying
to recreate it.

Added an AAAA record to the provider test so this stays covered.

Signed-off-by: churi12 <miguel_cristinha@hotmail.com>

* fix(dnsimple): disambiguate record lookup by type and verify ApplyChanges calls

GetRecordID matched on record name only, so once AAAA records became visible
to Records() a dual-stack host with both an A and an AAAA record at the same
name could resolve to the wrong record ID on delete or update. Pass the record
type through and filter the DNSimple lookup by name and type.

Also switch the Records() type guard to provider.SupportedRecordType() so the
read path stays in sync with the shared helper, and replace the ApplyChanges
test with a table-driven version that asserts the exact DNSimple API calls per
case (including dual-stack delete) via mock expectations.

Signed-off-by: churi12 <miguel_cristinha@hotmail.com>

* test(dnsimple): make Records test table-driven and self-contained

Rework testDnsimpleProviderRecords into a table-driven test with a fresh mock
per case instead of relying on shared global mock state. Cases cover all
supported record types returned together, a dual-stack host where an A and an
AAAA record share the same name, the apex domain mapping an empty record name
to the zone name, unsupported types being skipped, and error propagation from
both ListZones and ListRecords. Dro... (continued)

18252 of 21878 relevant lines covered (83.43%)

1423.56 hits per line

Jobs
ID Job ID Ran Files Coverage
2 run-ubuntu-latest - 28751058508.2 158
81.05
 GitHub Action Run
2 run-macos-latest - 28092647684.2 157
80.68
 GitHub Action Run
Source Files on build 28751058508