rtmx-ai / rtmx / 28749199767

83%

Build Type

push

github

Committed by web-flow

Commit Message

fix(verify): skipped results must not demote; add --no-demote raise-only mode (#129)

* fix(orchestration): don't leak GIT_* env into git worktree subcommands

CreateWorktree/RemoveWorktree shelled out to `git worktree` with the process
environment inherited verbatim. Git exports GIT_DIR, GIT_INDEX_FILE, and
GIT_WORK_TREE into hook and alias subprocesses, and when they leak into a
`git worktree add` child git resolves the new worktree's git dir/index against
the PARENT repository and fails ("fatal: .git/index: index file open failed:
Not a directory"). This makes the worktree helpers — and the repo's own
pre-commit hook, which runs `go test ./...` including the worktree tests —
fail whenever rtmx is invoked from a git-driven context on a git that exports
those variables.

Strip the per-invocation GIT_* variables before invoking git so it computes
the worktree's own paths from cmd.Dir. The existing worktree tests now pass
under a hook-like environment.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

* fix(verify): treat skipped results as non-evidence on the --results path

A skipped test result carried no representation in the cross-language results
schema: Result exposed only Passed bool, and the decoder folded status:"skip"
(and any record supplying neither passed nor status) into Passed=false. The
--results status engine then counted every non-passing record as a failure, so
under require_all_pass (the default) a single skipped test DEMOTED a COMPLETE
requirement to PARTIAL, and the shared count loop put the skip in TestsFailed —
making `rtmx verify --results` exit non-zero even without --update.

This was asymmetric with the native go-test path (determineNewStatus), which
keeps current status on a skip. Sharded/matrix CI that skips a test in one leg
therefore silently corrupted status on every run.

Add a Skipped tri-state to Result and decode status:"skip"/"skipped", an
explicit "skipped":true, and an absent-outcome record as skipped (n... (continued)

Coverage Stats

43 of 53 new or added lines in 3 files covered. (81.13%)

6 existing lines in 2 files now uncovered.

16660 of 19961 relevant lines covered (83.46%)

30.45 hits per line