kubernetes-sigs / kubebuilder / 28748277250

84%

push

github

⚠️ (go/v4): Remove deprecated `legacy` webhook flag introduced to help users migrate to the new layout where webhooks are under internal path (#5837)

breaking(go/v4): Remove deprecated --legacy webhook flag

The --legacy flag on `create webhook` scaffolded webhooks under the API
directory, the layout used before Kubebuilder v4.3.0. It was added in 2024
as a temporary migration aid after controller-runtime moved webhooks out
of the API package. The flag is create time only: it is not recorded in
the PROJECT file and the `alpha generate` flow never replays it, since
getWebhookResourceFlags only emits the --programmatic-validation,
--defaulting, --conversion and external API flags. A project scaffolded
with --legacy is therefore regenerated into the current layout regardless.
With the reorganize layout migration guide now available, the flag only
adds maintenance burden.

Remove the flag and its isLegacyPath plumbing from the go/v4 plugin (the
scaffolder, plus the IsLegacyPath branches and *Legacy template variants
in the webhook, webhook test, suite test and main.go templates), delete
the legacy-webhook-path CI workflow, its testdata script and the
`make test-legacy` target that ran it (with its .gitignore entry), and
update the deprecated flag example in the cli-descriptions skill.

Ref: https://github.com/kubernetes-sigs/kubebuilder/issues/5834

0 of 1 new or added line in 1 file covered. (0.0%)

7993 of 9527 relevant lines covered (83.9%)

97.05 hits per line