c-ares / c-ares / 28747214689

90%

Build Type

push

github

Committed by web-flow

Commit Message

Guard DNS record binary length overflow (#1168)

## Summary
- validate null-terminated DNS record binary allocation sizes before
adding the trailing NUL byte
- reject nonzero copy lengths with NULL input pointers in the public
binary/option setters
- add regression coverage for SIZE_MAX lengths across TXT ABINP, SIG
BINP, and OPT option paths

## Testing
- `/tmp/cmake-3.29.6-linux-x86_64/bin/cmake -S . -B build -G "Unix
Makefiles" -DCARES_BUILD_TESTS=OFF -DCARES_STATIC=ON -DCARES_SHARED=OFF`
- `/tmp/cmake-3.29.6-linux-x86_64/bin/cmake --build build -j2`
- `/tmp/cmake-3.29.6-linux-x86_64/bin/cmake -S . -B build-test -G "Unix
Makefiles" -DCARES_BUILD_TESTS=ON -DCARES_STATIC=ON -DCARES_SHARED=OFF
-DCMAKE_PREFIX_PATH=/tmp/googletest-cares-install`
- `/tmp/cmake-3.29.6-linux-x86_64/bin/cmake --build build-test -j2
--target arestest`
- `./build-test/bin/arestest
--gtest_filter=LibraryTest.DNSRecordRejectsInvalidBinaryInput`
- `./build-test/bin/arestest
--gtest_filter=LibraryTest.DNSRecord*:LibraryTest.DNSParseFlags`
- `./build-test/bin/arestest --gtest_filter=-*.Live*:*Live*` (1063 tests
passed)

Signed-off-by: @alb3e3

Coverage Stats

53 of 53 new or added lines in 2 files covered. (100.0%)

3 existing lines in 2 files now uncovered.

24144 of 26857 relevant lines covered (89.9%)

16136.68 hits per line