Borewit / music-metadata / 28741869204

95%

push

github

fix(mpeg): avoid negative bitrate/sampleRate for ADTS escape frequency index (#2644)

The MPEG-4 sampling-frequency index 15 is an escape value: the sampling
frequency is signalled explicitly elsewhere and cannot be derived from the
ADTS fixed header. The lookup table mapped this index to the sentinel -1
instead of null, so the bogus -1 was treated as a valid rate and propagated
into format.sampleRate and the ADTS bitrate calculation
(8 * bytesPerFrame * sampleRate / 1024), producing a negative bitrate.

Map index 15 to null like the other reserved indices (13, 14) so the existing
null-guards report an unknown rate instead of a negative one.

1604 of 1810 branches covered (88.62%)

Branch coverage included in aggregate %.

8570 of 8855 relevant lines covered (96.78%)

55480.57 hits per line