tamada / oinkie / 28728654492

74%

main: 74%

Build Type

Pull #18

github

Committed by tamada

Commit Message

perf: return borrows from Op::inputs and Op::ret instead of cloning

Op::inputs cloned the whole Vec<String> and Op::ret cloned the output
string on every call. extract_function_calls invoked inputs() once per
CALL op just to look at the first element, so extraction allocated and
copied every operand of every call for nothing.

Return &[String] / Option<&str> instead; the only implementor
(ghidra::Op) owns the data, so the borrows are free.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

Pull Request Pull Request #18: perf: return borrows from Op trait accessors instead of cloning

Coverage Stats

148 of 183 new or added lines in 8 files covered. (80.87%)

3 existing lines in 2 files now uncovered.

1611 of 2170 relevant lines covered (74.24%)

12.31 hits per line