ukeeper / ukeeper-readability / 28722516503

78%

push

github

Trim and drop empty lines when saving multi-line rule fields

saveRule split match_url, excludes and test_urls on "\n" only, so
browser-submitted \r\n left a trailing \r on every entry and blank lines
became empty-string entries, and this junk accumulated on every round-trip
through the edit form. New splitTrimLines trims each line and drops empties;
handlePreview reuses it in place of its ad-hoc split-and-trim loop.

Because splitTrimLines yields an empty slice for a blank textarea, the bson
"omitempty" on match_urls/excludes would have dropped the field from the
$set on update, silently keeping stale values. Drop the omitempty tags on
the form-editable fields (match_urls, excludes, use_cloudflare; test_urls
already lacked one) so clearing a field or unchecking the Cloudflare box
actually clears it, and normalise nil slices to []string{} in Save so
cleared arrays are stored as BSON arrays rather than null.

23 of 23 new or added lines in 2 files covered. (100.0%)

783 of 1000 relevant lines covered (78.3%)

9.77 hits per line