OpenCyphal-Garage / cy / 28719198695

100%

main: 100%

Build Type

push

github

Committed by pavel-kirienko

Commit Message

Fix M8 false-ack and harden reliable/ordered acceptance

Defer the dedup commit until a subscriber actually accepts a reliable
message: split the dedup primitive into check/touch/commit and commit
only at the tail of on_message gated on acceptance, so a message no
subscriber accepted is never recorded and its retransmit is retried
rather than falsely acked.

Follow-up review fixes:
- reordering_push refreshes recency before the late-drop returns, so a
  window-dropped, still-retransmitting reliable tag keeps its reordering
  state alive instead of being reaped after SESSION_LIFETIME and
  resurrected out of order with a false CY_OK.
- Derive the ack decision from subscriber_notify's delivery result
  (now returns bool) and consolidate the self-disposal handling into a
  single guard in reordering_push.
- Strengthen migration D06 with a per-future delivery-correlation
  assertion (CY_OK iff delivered) instead of disabling failure checks.
- Hoist the shared intrusive test fixture into intrusive_message_fixture.h.
- Assert the deferred-commit dedup entry survived the subscriber loop.

Full suite green under static analysis across x64/x32 x c99/c11.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

Coverage Stats

531 of 531 branches covered (100.0%)

Branch coverage included in aggregate %.

20 of 21 new or added lines in 1 file covered. (95.24%)

1 existing line in 1 file now uncovered.

2269 of 2283 relevant lines covered (99.39%)

407159.84 hits per line