source-academy / py-slang / 28709924213

78%

push

github

fix(stepper): report preprocessing errors identically to the default evaluator (#194)

* fix(stepper): report preprocessing errors identically to the default evaluator

preprocessPython already delegated name resolution to the same analyze()
pass the default (CSE) evaluator runs, but then discarded the analyzer's
own formatted NameNotFoundError message in favor of a simplified
"NameError: name 'x' is not defined" string. Every other analyzer error
already used the real message; only this one case diverged.

Return errors[0].message unconditionally instead, so a preprocessing
error (undefined name, chapter feature-gate, etc.) reads exactly the
same whether the program is run from the Stepper tab or any other
evaluator. Removes NameNotFoundError.varName, which existed solely to
build the now-deleted simplified string and had no other callers.

Updated the existing stepper preprocessing tests to the analyzer's real
message text.

* fix: remove dead ResolverErrors.BreakContinueError

Never constructed anywhere in the codebase — break/continue-outside-a-loop
validation is handled by validator/types.ts instead, which already
predates this class going unused. It was permanently uncovered, and
removing coverage-tested code elsewhere in this same file (the previous
commit) tipped the repo-wide coverage ratio below CI's threshold.
Deleting genuinely dead code fixes that honestly, rather than padding
coverage with a synthetic test for an unreachable path.

---------

Co-authored-by: Shrey Jain <“shreyjain5132@email.com>

2532 of 3485 branches covered (72.65%)

Branch coverage included in aggregate %.

6004 of 7363 relevant lines covered (81.54%)

13749.96 hits per line