jeremydaly / lambda-api / #220

83%

push

github

Add dual CJS/ESM build (#326)

* Add dual CJS/ESM build

* Update package-lock.json

* ci: build dual package once, run test matrix against prebuilt dist

The SWC build toolchain requires Node >= 16.14, so the Node 14 test job could
no longer build. Restructure CI to build the CJS/ESM output once on Node 20 and
share dist/ as an artifact, then run the Node 14-22 test matrix against that
prebuilt output (npm run test:prebuilt). This preserves runtime testing on all
supported Node versions without building on the ones the toolchain can't run on.

- pull-request.yml / release.yml: add a build job (build + tsd + upload dist),
  make the test matrix download dist and run tests without rebuilding
- build.yml: bump the coverage job from Node 14 to 20 (build tooling floor)
- add the test:prebuilt script (jest unit against an existing dist/)

* Fix eager AWS SDK load under ESM refactor + add dual-package e2e suite

The dual CJS/ESM refactor turned lambda-api's lazy S3 loading into static
top-level imports: src/index.js and src/lib/response.js statically import
s3-service, which statically imported @aws-sdk/*. That made require('lambda-api')
/ import 'lambda-api' throw "Cannot find module '@aws-sdk/client-s3'" whenever
the OPTIONAL peer deps weren't installed — breaking every non-S3 consumer — and
constructed an S3Client at module-eval time on every import.

Fix (src/lib/s3-service.js only): load @aws-sdk and construct the S3 client
lazily via dynamic import() inside the service, on first real S3 use. Keeps the
named exports getObject/getSignedUrl/setConfig and the synchronous setConfig the
existing unit tests rely on (sinon stubs + constructor assertion). SWC compiles
import() to a lazy require() in the CJS build and keeps native import() in ESM.
Also add "./package.json" to the exports map.

Add an extensive e2e suite (e2e/, excluded from the tarball):
 - Layer 1 (no Docker): installs the packed tarball into isolated CJS/ESM/deep-
   import/esbuild-.mjs(#295)... (continued)

804 of 983 branches covered (81.79%)

Branch coverage included in aggregate %.

766 of 915 relevant lines covered (83.72%)

121.29 hits per line