wegamekinglc / Derivatives-Algorithms-Lib / 28702145923

83%

master: 85%

Pull #205

github

Fix SupEqual const-fold and restore &&/|| short-circuit

Phase 1b of the compiled/tree-walk alignment (defects #5 and #2 from
.claude/specs/script-compiled-evaluator-alignment.md).

#5 SupEqual const-fold: Compiler_::VisitCondition<SupEqual> folded via
(x > -EPSILON) while the runtime SupEqual opcode uses (x >= 0) - divergent
for x in (-EPSILON, 0). Changed the fold predicate to x >= 0.0 so the
compiled path matches the runtime exactly. The fold is unreachable through
the public PreProcess -> Compile pipeline (ConstCondProcess crisps fully-
const conditions first), so the fix is verified by a direct Compiler_ unit
test at the visitor level.

#2 short-circuit loss: Compiler_::Visit(NodeAnd_)/Visit(NodeOr_) emitted
both RHS sub-streams unconditionally and the And/Or opcodes merged them,
while the tree-walk short-circuits (Evaluator_::Visit(NodeAnd_)/NodeOr_).
Added two opcodes (AndIfFalse, OrIfTrue) emitted as a 2-slot guard between
the LHS and RHS sub-streams; the guard peeks the LHS bool on bStack and
jumps past the trailing And/Or merge when the LHS decides the boolean, so
the RHS sub-stream is genuinely skipped (not executed). When the LHS does
not decide, the RHS executes and the existing And/Or opcodes merge LHS+RHS
as before. Mirrors evaluator.hpp:187-201 exactly.

Verification (the parity pins for #2 and #5 pass even on the unfixed code,
so primary verification is via direct Compiler_ unit tests):
- TestAndShortCircuit_SkipsRhsWhenLhsFalse: hand-builds a NodeAnd_ whose
  RHS is a state-mutating assignment; asserts the AndIfFalse opcode is
  emitted, that LHS=false leaves the marker unchanged (RHS skipped), and
  that LHS=true writes the marker (RHS executed).
- TestOrShortCircuit_SkipsRhsWhenLhsTrue: symmetric for OrIfTrue.
- TestSupEqualConstFold_TinyNegativeIsFalse_TinyPositiveIsTrue: drives
  Visit(NodeSupEqual_) directly on const children; asserts a tiny-negative
  folds to False (was True pre-fix) and tiny-positive/zero to True.
- Enabled t... (continued)

13 of 13 new or added lines in 1 file covered. (100.0%)

6479 of 7829 relevant lines covered (82.76%)

3318459.53 hits per line