ingitdb / dalgo2ingitdb4github / 28701443176

84%

push

github

fix: encode dal.Key parent chain into record path (per-parent scoping) (#2)

The adapter mapped a dal.Key to an in-repo record path using only the leaf
collection + record id, dropping the key's parent chain. Two keys sharing a
leaf but living under different parents — e.g. spaces/family/contacts/c1 and
spaces/work/contacts/c1 — resolved to the same path and clobbered each other
(no per-space scoping).

Add resolveScopedCollection, which walks key.Parent() and interleaves each
ancestor record id with its subcollection name into the DirPath, mirroring
Firestore-style nesting (spaces/<spaceID>/contacts/...). This matches the
Option A layout already shipped in github.com/ingitdb/dalgo2ingitdb v0.1.0, so
the write and read paths agree with the sibling adapters. Top-level (non-nested)
keys are unchanged: a plain flat def.Collections lookup.

Route both resolveCollection (Set/Insert/Delete, incl. the batching tx) and the
previously-inlined Get through the scoped resolver so reads and writes agree.

Regression tests: two keys with the same leaf id under different parents map to
DISTINCT paths, plus an end-to-end round-trip proving a record written under one
parent is not visible/overwritten under another.


Claude-Session: https://claude.ai/code/session_01FV3pbooAc9UPpNdiaJuKve

Co-authored-by: Alexander Trakhimenok <alex@Alexanders-MacBook-Pro.local>
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

50 of 54 new or added lines in 2 files covered. (92.59%)

964 of 969 relevant lines covered (99.48%)

1.17 hits per line