gookit / config / 28692475283

98%

push

github

fix(read): Duration() parses Go duration strings (e.g. "300s", "1h30m") (#218)

The Config.Duration getter read the value as an int64 and returned
time.Duration(n) — i.e. nanoseconds — so a duration string like "300s" could
not be read at all (it failed integer parsing and yielded 0), and a bare
number was interpreted as nanoseconds. Duration parsing existed only on the
struct-binding path (ParseTime decode hook), not the getter.

Parse the stored value as a Go duration string first (time.ParseDuration),
falling back to the previous int64-nanoseconds behaviour for bare integers,
then to the default. Backwards compatible; adds a getter test.

13 of 14 new or added lines in 1 file covered. (92.86%)

1223 of 1246 relevant lines covered (98.15%)

5.71 hits per line