umputun / reproxy / 28691253684

80%

master: 80%

Build Type

Pull #255

github

Committed by paskal

Commit Message

Fix load balancing on catch-all server broken by default-route dedup

Previously, the dedup added for #192 removed a default-server route
whenever more than one route matched, without checking that a concrete
server match was actually present. With multiple routes for the same
source on the catch-all server (a legit load-balancing setup) one of
them was silently dropped, so traffic always went to a single backend
and failover could return 502 while a healthy backend existed. It also
removed only one default route when several matched alongside a
concrete one.

The dedup ran only at the end of the match loop, so both the
presorted-src early return and the MTStatic branch's own return
bypassed it: a concrete proxy plus a same-source catch-all route (proxy
or assets) leaked a mixed match, in the static case even flipping the
result to MTStatic.

After this change the default/concrete dedup runs at every return point
of Match. A shared isDefaultServer helper centralises the "*"/"" check,
default-server routes are dropped only when at least one concrete server
route matched, all of them are dropped in that case, and an all-default
match keeps every route so catch-all load balancing works.

Pull Request Pull Request #255: Fix load balancing on catch-all server broken by default-route dedup

Coverage Stats

35 of 35 new or added lines in 1 file covered. (100.0%)

2 existing lines in 1 file now uncovered.

2634 of 3309 relevant lines covered (79.6%)

40.23 hits per line