umputun / reproxy / 28688439372

80%

master: 80%

Build Type

Pull #255

github

Committed by paskal

Commit Message

Fix load balancing on catch-all server broken by default-route dedup

Previously, the dedup added for #192 removed a default-server route
whenever more than one route matched, without checking that a concrete
server match was actually present. With multiple routes for the same
source on the catch-all server (a legit load-balancing setup) one of
them was silently dropped, so traffic always went to a single backend
and failover could return 502 while a healthy backend existed. It also
removed only one default route when several matched alongside a
concrete one.

The dedup ran only at the end of the match loop, so the presorted-src
early return (triggered by a shorter default src following the matched
one) bypassed it entirely and leaked a catch-all route alongside the
concrete match.

After this change, the default/concrete dedup is a single helper applied
at both the early return and the final return: default-server routes are
dropped only when at least one concrete server route matched, all of
them are dropped in that case, and an all-default match keeps every
route so catch-all load balancing works.

Pull Request Pull Request #255: Fix load balancing on catch-all server broken by default-route dedup

Coverage Stats

32 of 33 new or added lines in 1 file covered. (96.97%)

1 existing line in 1 file now uncovered.

2619 of 3293 relevant lines covered (79.53%)

38.89 hits per line