c-ares / c-ares / 28687754304

90%

push

github

ares_sysconfig_files: recognize AIX netsvc.conf bind4/local4 tokens (#1188)

`config_lookup()` only matched the bare `bind`/`dns`/`resolv` and
`files`/`file`/`local` tokens. AIX `/etc/netsvc.conf` uses
address-family-suffixed variants — `bind4`/`bind6` and `local4`/`local6`
(e.g. `hosts = local, bind4`).

Those suffixed tokens fell through to the ignore branch, so a
configuration like `hosts = local, bind4` recorded only the `files`
source and **never attempted DNS** — the reported regression (#986).

### Change
- Match the suffixed forms in addition to the bare ones in
`config_lookup()`.

### Test
Adds a container test injecting `/etc/netsvc.conf` with `hosts = bind4,
local4` and asserting the resulting lookup order is `"bf"`. This differs
from the default `"fb"`, so the test fails if the suffixed tokens are
ignored (pre-fix) and passes only when they are parsed.

Note: the functional test is a `CONTAINED_TEST_F` (Linux user-namespace
container), mirroring the existing `ContainerSvcConfInit` test —
`config_lookup()` is only reached on the file-based sysconfig path
(Linux/AIX/etc.); macOS and several other platforms use native config
readers that bypass it, so this cannot be exercised outside the
container harness.

Fixes #986

Signed-off-by: Brad House <brad@brad-house.com>

10 of 10 new or added lines in 2 files covered. (100.0%)

23791 of 25983 relevant lines covered (91.56%)

12385.16 hits per line