archetech / archon / 28686877020

92%

push

github

fix(satoshi-mediator): re-point registered[] at the live txid on RBF bump (#689) (#690)

registered[] entries were written once at anchor time with the initial broadcast
txid and never updated when RBF bumped the fee — so after an RBF replacement, the
entry kept pointing at the superseded txid that gets dropped from mempool and
never confirms, leaving orphans that accumulate in registered[].

The RBF path already has both the superseded txid and its replacement, so update
the matching registered entry's txid -> newTxid in the same updateDb block (next
to the pending.txids push). This chains correctly across multiple bumps
(orig -> bump1 -> bump2 ...) since each cycle bumps the current live txid, which
is what the entry now holds. Keeps registered[] as ground truth for landed
anchors going forward.

Note: prevents future RBF orphans; pre-existing orphaned rows are a one-time
cosmetic data cleanup handled by the operator. The satoshi mediator has no test
harness (module has import-time side effects); change mirrors the adjacent
pending.txids update and is build-verified.

Closes #689.

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

2816 of 3323 branches covered (84.74%)

Branch coverage included in aggregate %.

5851 of 6142 relevant lines covered (95.26%)

882.15 hits per line