couchbase
/
cbgt
/
199
54%
|
Ran
|
Jobs
1
|
Files
56
|
Run time
4s
|
Badge
Embed ▾
README BADGES
|
push
travis-ci
steveyenMB-20205 - cached nodeDefs when calculating covering pindexes To process a query, a set of covering pindexes (or shards) for an index need to be computed. As part of that, the previous code would lookup the latest nodeDefs in the Cfg. When the Cfg is metakv, that would mean a REST call from cbft to ns-server which may be slow. Additionally, that Cfg retrieval would happen while holding the cbgt manager's lock. Quite slow. For some reason, I had mistakenly thought cbauth/metakv provided caching, but it apparently does not. Props to Alex Gyryk for finding the clues here, noticing that ns-server CPU was extremely high during perf tests, and from Pavel Paulau for the hint to check ns-server's access log. This change introduces cached nodeDefs, which has the downside that under a topology change, the system might have a longer window of attempting to use an outdated, previously cached nodeDefs, meaning that queries may see more partial result errors during rebalance. Change-Id: Icf13a99ad Reviewed-on: http://review.couchbase.org/67975 Reviewed-by: Marty Schoch <marty.schoch@gmail.com> Tested-by: Steve Yen <steve.yen@gmail.com>
6306 of 11022 relevant lines covered (57.21%)
27.06 hits per line
Jobs
| ID | Job ID | Ran | Files | Coverage | |
|---|---|---|---|---|---|
| 1 | 199.1 | 0 |
57.21 |
Travis Job 199.1 |
Source Files on build 199
Detailed source file information is not available for this build.