jzombie / term-wm / 28682932637

75%

push

github

fix: PTY scrollback regression (#80)

make screen() return &cached_screen so scrollback mutations are visible

Pty::screen() was returning screen_arc.as_deref() (the raw ArcSwap
snapshot), but set_scrollback() mutations went to cached_screen via
screen_mut(). This meant scrollback() and screen().scrollback() always
returned the stale value, breaking terminal viewport scrolling.

Fix: on dirty, clone the fresh ArcSwap screen into cached_screen inside
screen(), then always return &cached_screen. Remove the redundant clone
from screen_mut() since screen() already handles it.

Add regression tests:
set_scrollback_mutation_visible_through_scrollback_and_screen
and screen_mut_then_screen_see_consistent_scrollback.

81 of 83 new or added lines in 1 file covered. (97.59%)

13124 of 19245 relevant lines covered (68.19%)

142.76 hits per line