umputun / remark42 / 28682472386

84%

Build Type

push

github

Committed by umputun

Commit Message

feat(api): adopt enforcing rest.Timeout, drop local cooperative timeout

go-pkgz/rest v1.22.0 ships an enforcing Timeout middleware (net/http.TimeoutHandler
style): it runs the handler with a deadline and returns 504 at the deadline even if
the handler ignores the context - unlike the local cooperative timeout, which only
cancelled the context and never actually stopped a stuck handler.

Replace the local timeout with rest.Timeout on every route with a bounded response.
The streaming and long-polling routes are deliberately left without it, since the
enforcing timeout buffers the whole response in memory and aborts at the deadline:
- GET /api/v1/userdata and GET /api/v1/admin/export stream gzipped exports
- GET /api/v1/admin/wait long-polls for up to 15m
- POST /api/v1/admin/import[/form] and /remap ingest large uploads

Delete the local timeout middleware and its test; the enforcing behaviour is covered
by go-pkgz/rest. TestRouteTimeout locks the enforcing-vs-exempt contract in this build.

Coverage Stats

34 of 34 new or added lines in 2 files covered. (100.0%)

9 existing lines in 2 files now uncovered.

6396 of 7580 relevant lines covered (84.38%)

36.84 hits per line