umputun / tg-spam / 28681829406

84%

push

github

fix: data race on approvedUsers map in Detector.Check (#405)

* fix: guard approvedUsers map with dedicated mutex to prevent concurrent map writes

Detector.Check updates the approvedUsers map while holding d.lock as a read
lock only, so two concurrent Check calls on the approval path (FirstMessageOnly
is on by default) crash with a concurrent map write. The web /check API with
check_only:false is a live concurrent vector.

Add a leaf-level auLock guarding all approvedUsers access and a concurrency
regression test that fails under -race on the previous code.

* fix: cap approved count at approved level under concurrency

Concurrent first messages from the same user can all pass the pre-approved
check before any increment lands, pushing the count past FirstMessagesCount.
The short-msg-flood check subtracts the approved count from the total, so an
inflated count delays flood detection. Cap the increment under auLock and
cover with a same-user concurrency test. Flagged by codex review.

* fix: cap organic approved count at FirstMessagesCount

The previous cap of FirstMessagesCount+1 still let concurrent checks push the
count one above what sequential flow can produce; the +1 sentinel is reserved
for explicit AddApprovedUser and storage-loaded users. Add a deterministic cap
test using FirstMessageOnly=false where every ham message hits the increment.
Flagged by codex re-review.

31 of 33 new or added lines in 1 file covered. (93.94%)

8504 of 10186 relevant lines covered (83.49%)

252.11 hits per line