umputun / rlb-stats / 28681705165

85%

master: 83%

Build Type

Pull #59

github

Committed by paskal

Commit Message

fix: merge same-minute candles on save instead of overwriting

Bolt.Save keyed candles by StartMinute.Unix() and did a plain Put, so a second
candle for the same minute overwrote the first. This happens when the aggregator
flushes a partial minute on shutdown and the process restarts within that same
minute: the restart's candle replaced the flushed one and its stats were lost.

Merge the incoming candle with any candle already stored for the same key. Normal
operation saves each minute once and never merges; the merge only runs on this
abnormal duplicate-key path. Counts are summed, so an ip+file pair spanning two
fragments can be over-counted - accepted as best-effort recovery versus the
previous behaviour of dropping the earlier fragment entirely.

Pull Request Pull Request #59: fix: merge same-minute candles on save instead of overwriting

Coverage Stats

24 of 26 new or added lines in 2 files covered. (92.31%)

6 existing lines in 1 file now uncovered.

340 of 405 relevant lines covered (83.95%)

10.12 hits per line