mindersec / minder / 28680578884

61%

push

github

feat: implement mindev test cli command and rule loading by name (#6551)

* feat: implement mindev test cli command and rule loading by name

* fix: address reviewer feedback on mindev test command and ruletest

- Fix GCI import ordering in runner.go (minder imports in separate section)
- Restore errors.AsType in RunFile for proper error-wrapping support
- Make RunDir private; TestDir now delegates to RunPaths to remove duplication
- Rename ruleNameOrPath to ruleName in builtinEval for clarity
- Update mindev test Use field to accept files or directories

* fix: address second round of reviewer feedback on ruletest

- Remove t.Parallel() from TestDir to prevent panic when caller already called it
- Add Filename field to TestResult; TestDir groups sub-tests by file/name
- Restore more descriptive RunFile doc comment explaining src parameter
- Remove path fallback from rule lookup: eval() now only accepts rule names,
  not file paths, resolving the dual-typed argument complexity
- Update testdata/eval.star to reference rule by name (branch_protection_reviews)
  instead of file path (rule_type_sample.yaml)
- Load ruleTypes in TestRunEvalFile so name-based lookup works in tests
- Remove nil guard from mapToProto: empty entity maps now correctly flow
  through to the engine instead of silently returning nil

* fix: address PR #6551 review comments

- Addressed Evan's feedback on testkit mocking (refactored to gitFS/WithGitFiles)
- Fixed 'err' return values in cmd/dev/app/test/test.go
- Added filename prefix to CLI test output
- Fixed defer Close() pattern in ruletest/runner.go
- Updated RunFile godoc

* Address remaining PR comments from Evan

- Add test_fail_ prefix support to TestDir

- Simplify runner_test.go to use TestDir

- Rename intentionally failing tests in sample.star to use test_fail_ prefix

* feat: integrate filesystem mocking in ruletest eval

* chore: fix PR comments from latest review

* chore: fix golangci-lint errors (gci and revive)

84 of 100 new or added lines in 2 files covered. (84.0%)

20805 of 34201 relevant lines covered (60.83%)

39.62 hits per line