umputun / ralphex / 28680404841

84%

master: 84%

Build Type

Pull #400

github

Committed by paskal

Commit Message

fix: bound force-exit cleanup so a stuck worktree removal cannot prevent exit

The interrupt watcher's 5s force-exit path called the worktree cleanup
directly before os.Exit(1). That cleanup shares a sync.Once with the
graceful shutdown's deferred cleanup, so when the deferred call was
already in flight and stuck (e.g. a hanging git worktree remove), the
watcher blocked inside Once.Do forever and the promised force exit
never happened. Run the cleanup in a goroutine and wait at most 5s
before exiting regardless.

Pull Request Pull Request #400: fix: bound force-exit cleanup so a stuck worktree removal cannot prevent exit

Coverage Stats

13 of 14 new or added lines in 1 file covered. (92.86%)

2 existing lines in 1 file now uncovered.

7794 of 9305 relevant lines covered (83.76%)

226.38 hits per line