ukeeper / ukeeper-readability / 28679477920

78%

master: 78%

Pull #82

github

Fix top-3 review findings: SSRF, textarea CRLF corruption, image fetch

Block SSRF via user-supplied URLs. Extraction and image fetches now
reject targets resolving to loopback, private, link-local or other
non-public addresses via a net.Dialer Control hook (checks the actual
IP at connect time, so it also covers redirects and DNS rebinding).
Gated by BlockPrivateNetworks, wired on in main; default stays permissive
so httptest-based tests keep working. `POST /api/extract` was and remains
unauthenticated, so this is the real mitigation.

Stop corrupting multi-line rule fields. saveRule split match_url,
excludes and test_urls on "\n" only, so browser-submitted \r\n left a
trailing \r on every entry and blank lines became empty strings. New
splitTrimLines trims and drops empties; handlePreview reuses it.

Rework image sizing. getImageSize buffered every image fully into memory
with a fresh client per image, no context and unbounded per-page
goroutines. Now it streams to io.Discard behind an io.LimitReader (10MB
cap), shares one client, honors the request context and caps concurrency
at 8 probes per page.

60 of 69 new or added lines in 6 files covered. (86.96%)

800 of 1026 relevant lines covered (77.97%)

9.57 hits per line