stacklok / toolhive / 28664585621

68%

Build Type

push

github

Committed by web-flow

Commit Message

Replace opaque Step A/B labels in XAA CRD comments (#5703)

* Replace opaque Step A/B labels in XAA CRD comments with action names

"Step A" and "Step B" in the XAASpec struct comments and the generated
CRD YAML descriptions don't tell the reader what each step does or which
endpoint it targets. Rename throughout to "IdP exchange" (RFC 8693 token
exchange at the user's IdP, produces the ID-JAG) and "target grant"
(RFC 7523 JWT bearer grant at the target AS, produces the backend access
token). Regenerate the CRD YAML with task operator-manifests.

Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>

* Rename remaining XAA Step A/B labels

The initial rename only touched mcpexternalauthconfig_types.go, leaving
pkg/vmcp/auth/types/types.go and pkg/vmcp/auth/strategies/xaa.go with the
old "Step A"/"Step B" labels for the identical ID-JAG exchange. Since
types.go feeds the VirtualMCPServer CRD schema, kubectl explain showed
two different names for the same protocol concept depending on which
CRD you asked.

Extend the IdP exchange / target grant rename to the runtime auth
types, the XAA strategy implementation (including the
performStepA/performStepB function names, log strings, and error
messages), and two incidental mentions in the generic OAuth protocol
packages. Regenerate the VirtualMCPServer and MCPExternalAuthConfig CRD
YAML and the CRD API reference docs to match, fixing the CI doc-drift
failure. Also drop a stray "the" before "IdP exchange" for consistency
with the rest of the file.

---------

Co-authored-by: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>

Coverage Stats

15 of 16 new or added lines in 1 file covered. (93.75%)

172 existing lines in 7 files now uncovered.

72446 of 106987 relevant lines covered (67.71%)

64.31 hits per line